Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Change to avoid specific XF versions #6

Closed
jdluzen opened this issue Sep 5, 2016 · 2 comments
Closed

Change to avoid specific XF versions #6

jdluzen opened this issue Sep 5, 2016 · 2 comments

Comments

@jdluzen
Copy link

jdluzen commented Sep 5, 2016

Thanks for this project, I just started looking into it!

Is it feasible to change the Nuget package to require a minimum version of XF? I know some packages are forced to require a specific version for compatibility reasons, and others can do simple minimums.

@tbaggett
Copy link
Owner

tbaggett commented Sep 5, 2016

You're welcome! Thanks for checking it out. I look forward to hearing your feedback.

Yeah, XFGloss can be changed so that v2.3.1.114 is the minimum XF version instead of the required one. See my reasons for requiring a specific version below, but if you want to test XFGloss against XF beta/alpha releases, I'm okay with changing it to the minimum version. Be aware that I may switch it back though if my concerns prove to be valid. 😄

I locked the version because some of the XFGloss enhancements interact with internal implementations in XF, so XF updates are more likely to break them.

I'm also concerned about getting issues raised against XF beta/alpha releases, as I only use Xamarin stable channel releases for development.

Finally, I took a cue from XF itself, which requires v23.3.0 of the Android support libraries.

tbaggett added a commit that referenced this issue Sep 5, 2016
Changed the nuspec file to specify XF 2.3.1.114 as the minimum version instead of being the specific supported version per request #6.
@tbaggett
Copy link
Owner

tbaggett commented Sep 5, 2016

Okay, a new version of the NuGet package (v1.0.3.35) has been pushed to nuget.org. It should show up as soon as their indexing catches the update. Please let me know if you run into issues with it on the XF pre-releases. Thanks!

@tbaggett tbaggett closed this as completed Sep 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants