Verbosity switches #1165
Closed
Verbosity switches #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2023
schlimmchen
force-pushed
the
verbosity-switches
branch
from
b83d7a6
to
5b1a452
Compare
|
This PR requires some work for it could be able to be merged into the current state of branch master. @tbnobody please let me know if this change is interesting to you. If not, please reject this PR and close it. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement two user-controlled switches that allow to decrease verbosity of the Hoymiles lib and the MQTT component. The behavior does not change with the new default: all messages are printed as before. But there is now an option to decrease the amount of messages produced by the Hoymiles library and the MQTT component. The former still prints hex dumps of messages in particular, and I argue that the project is past analyzing the protocol in such detail. The latter prints a message for every update of every topic, which can be very noisy.