Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre commit tools as normal dependencies #16

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

tbrlpld
Copy link
Owner

@tbrlpld tbrlpld commented Feb 2, 2024

This is in preparation to make mypy work. For mypy to properly work, it needs to be installed in the same environment as the module it's checking. Pre-commit usually creates separate environments for its hooks. This PR changes that and implements the same checkers with custom hooks that use the local executables.

https://pre-commit.com/#repository-local-hooks

This is to make sure that coverage is available in the dev environment to be able to do
things like show the coverage report or erase the coverage database.

The nameing change is to better reflect the usage.
The types should be enough and leave the file identification to the
identity library.
@tbrlpld tbrlpld marked this pull request as ready for review February 2, 2024 04:43
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05c356a) 100.00% compared to head (aa2aeee) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          212       212           
=========================================
  Hits           212       212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tbrlpld tbrlpld merged commit 90fb2c5 into main Feb 2, 2024
8 checks passed
@tbrlpld tbrlpld deleted the pre-commit-tools-as-normal-dependencies branch February 2, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant