Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests #6

Merged
merged 109 commits into from
Jan 25, 2024
Merged

Add more tests #6

merged 109 commits into from
Jan 25, 2024

Conversation

tbrlpld
Copy link
Owner

@tbrlpld tbrlpld commented Dec 11, 2023 •
edited
Loading

This PR adds a lot of new test and refactors previously existing tests so that each test is more focused.

Test are added for different scenarios:

  • the basic Component class,
  • targeted subclasses of the Component class to test features not testable with the basic Component class (e.g. rendering of a real template),
  • the MediaContainer class,
  • usages of the component template tag,
  • example use cases of components - these somewhat duplicate some of the previous tests but are closer to what I would imagine the use cases of components to look like.

It also adds configuration set up to make use the CodeCov.io platform.

@tbrlpld
Move example component to keep handling simpler
f0fc1f6
@tbrlpld
Rename tempalte and variables to express what they test
4bf808b
@tbrlpld
Test rendering of static template
f5f5365
@tbrlpld
Test component that passes fixed value to template context
fc3aa9e
@tbrlpld
Flip order of methods in Component to higher level at top
fbd4903 
I usually find it easier to reason about modules and classes when the
higher level code it at the top. I also think it's nice when the order
somewhat follows the control flow.
@tbrlpld
Add test for the basic Component class
4c1bd4f
@tbrlpld
Add test for media property
e598382
@tbrlpld
Add test for subclass that defines a template name
aa379eb
@tbrlpld
Create example template in test code
f434c3b
@tbrlpld
Test for SafeString
2184738
@tbrlpld
Include randomness in example template file names
939ac36
@tbrlpld
Test rendering with context value
c3fe1c2
@tbrlpld
Test render_html when get_context_data returns None
ee5076e 
The implementation has a special case for some reason.
@tbrlpld
Remove empty models file
64a84b2
@tbrlpld
Add method docstring
77751af
@tbrlpld
Use Markdown in docstring over reStructuredText
396d06d
@tbrlpld
Add first media container test
26878bb
@tbrlpld
Add second test for media container
2f5dd70
@tbrlpld
Test empty container
5caaf10
@tbrlpld
Test members of different classes
f0824c7
@tbrlpld
Expand MediaContainer docstring
5cc1c5c
@tbrlpld
Test nested Media class def in Component subclass
d1c14fa
@tbrlpld
Remove reliance on os_helper module
3149f3b
@tbrlpld
Add test docstring
649f8a8
@tbrlpld
Add test with only mock component in context
37b0de4
@tbrlpld
Test other variable in context
2aa7b1e
@tbrlpld
Test with sets extra context
af05b78
@tbrlpld
Rename context variable to avoid shadowing
c324390
@tbrlpld
Test with block sets extra context
bff31c2
@tbrlpld
Refactor helper
288f58c
@tbrlpld tbrlpld changed the title Add tests Add more tests Jan 1, 2024
tbrlpld
tbrlpld commented Jan 1, 2024
View reviewed changes
README.md Show resolved Hide resolved
tbrlpld
tbrlpld commented Jan 1, 2024
View reviewed changes
README.md Show resolved Hide resolved
@tbrlpld tbrlpld self-assigned this Jan 5, 2024
@tbrlpld tbrlpld requested a review from gasman January 5, 2024 03:18
@tbrlpld tbrlpld marked this pull request as ready for review January 5, 2024 03:18
@tbrlpld tbrlpld merged commit fe8a7ec into main Jan 25, 2024
7 checks passed
@tbrlpld tbrlpld deleted the add-tests branch January 25, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasman gasman Awaiting requested review from gasman

Assignees

@tbrlpld tbrlpld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbrlpld @codecov-commenter