Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Add subscripts to BindingIdentifier static semantics. #1885

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Editorial: Add subscripts to BindingIdentifier static semantics. #1885

merged 1 commit into from
Mar 25, 2020

Conversation

marjakh
Copy link
Contributor

@marjakh marjakh commented Feb 27, 2020

Adding subscripts here makes sense, because the semantics specifically talk
about the presence of a parameter.

Also, the productions below, where the semantics also talk about the presence
of a parameter, already have the subscripts. So it's inconsistent to not have
them here.

@ljharb ljharb requested review from michaelficarra, syg, bakkot and a team February 27, 2020 19:17
@bakkot

This comment has been minimized.

@jmdyck

This comment has been minimized.

@bakkot

This comment has been minimized.

Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I like listing these when they actually affect the semantics.

@ljharb ljharb self-assigned this Mar 12, 2020
@ljharb ljharb requested a review from a team March 12, 2020 03:03
@ljharb
Copy link
Member

ljharb commented Mar 12, 2020

@marjakh
Copy link
Contributor Author

marjakh commented Mar 12, 2020

I work at Google and I was under the impression we're covered somehow. Isn't that the case? This is my second contribution and I don't remember what i did the first time, whether I registered to something or not. It was a while back. I can try to search my e-mail for history, if needed.

@syg
Copy link
Contributor

syg commented Mar 12, 2020

I work at Google and I was under the impression we're covered somehow. Isn't that the case? This is my second contribution and I don't remember what i did the first time, whether I registered to something or not. It was a while back. I can try to search my e-mail for history, if needed.

This is a good point, though unfortunately there's no easy way to check for employer. The best approximation we came up with is check for public membership in https://github.com/googlers. @marjakh Could you please join that at go/github, then go to https://github.com/googlers, search for your handle and set your membership to Public?

@marjakh
Copy link
Contributor Author

marjakh commented Mar 12, 2020

Done!

@littledan
Copy link
Member

Yes, people who work for member companies are generally covered, and should not sign the contributor form. Glad this has been sorted out.

Adding subscripts here makes sense, because the semantics specifically talk
about the presence of a parameter.

Also, the productions below, where the semantics also talk about the presence
of a parameter, already have the subscripts. So it's inconsistent to not have
them here.
@ljharb ljharb merged commit 567bd0e into tc39:master Mar 25, 2020
@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Mar 30, 2020
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants