Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: rename EnumerableOwnPropertyNames to EnumerableOwnProperties #2899

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

michaelficarra
Copy link
Member

Since this AO takes a kind where 2 of the 3 values cause it to not return names, I felt EnumerableOwnPropertyNames was a poor name for it.

@bakkot
Copy link
Contributor

bakkot commented Sep 6, 2022

This reverts #1113. Note that this does affect downstream consumers; specifically the structured clone algorithm calls this.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Sep 6, 2022
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
@michaelficarra michaelficarra added editor call to be discussed in the next editor call ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed editor call to be discussed in the next editor call labels Sep 8, 2022
@ljharb ljharb merged commit e30935d into main Sep 9, 2022
@ljharb ljharb deleted the EnumerableOwnProperties branch September 9, 2022 06:05
domenic pushed a commit to whatwg/html that referenced this pull request Sep 12, 2022
ptomato added a commit to tc39/proposal-temporal that referenced this pull request Oct 11, 2022
This will be necessary for the rebase on
tc39/ecma262#2781

Delete the reference to LocalTZA which no longer exists in ECMA-262; this
reference was already inside text to be deleted from ECMA-402 anyway.

EnumerableOwnPropertyNames was renamed to EnumerableOwnProperties in
tc39/ecma262#2899 so that change also needs to be
made when pulling in the new biblio.
Ms2ger pushed a commit to tc39/proposal-temporal that referenced this pull request Oct 11, 2022
This will be necessary for the rebase on
tc39/ecma262#2781

Delete the reference to LocalTZA which no longer exists in ECMA-262; this
reference was already inside text to be deleted from ECMA-402 anyway.

EnumerableOwnPropertyNames was renamed to EnumerableOwnProperties in
tc39/ecma262#2899 so that change also needs to be
made when pulling in the new biblio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants