Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Replace the single-row time zone code points table #3098

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 commented Jun 14, 2023

The single-row Time Zone Offset String Code Points table takes up a large amount of visual space for little practical benefit. This PR replaces it with direct use of <U+2212 MINUS SIGN> in the only grammar production that references the abbreviation defined by the table.

spec.html Outdated Show resolved Hide resolved
@michaelficarra
Copy link
Member

Personally, I'd prefer to do this for tables 34 and 35 as well.

spec.html Outdated
@@ -32725,7 +32697,7 @@ <h2>Syntax</h2>

TemporalSign :::
ASCIISign
&lt;MINUS&gt;
&lt;U+2212 MINUS SIGN&gt;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but we typically parenthesise the code point name.

Suggested change
&lt;U+2212 MINUS SIGN&gt;
&lt;U+2212 (MINUS SIGN)&gt;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not consistent about the parentheses, although it's true that they are much more common than not (exceptions being concentrated in Canonicalize, plus one outlier in Appendix F).

But this particular suggestion also has the drawback that it will be rejected by the just-released version of ESMeta (which AFAICT was only extended to allow <U[+]([1-9A-F]|10)?[0-9A-F]{4}( \w+)*>), and beyond that I'd like to get to a point where ECMA-262 and 402 hew more closely to Unicode conventions (i.e., "U+…" followed by an unpunctuated uppercase name [in small caps where possible]). Given that, is appearance inside a grammar as a nonterminal sufficient distinction for omitting the parentheses here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either way is fine, I was just trying to match our current conventions. I'll bring it up in editor call.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Jun 15, 2023
@gibson042
Copy link
Contributor Author

Personally, I'd prefer to do this for tables 34 and 35 as well.

Agreed! Should I extend this PR to do so?

@michaelficarra
Copy link
Member

@gibson042 We'll probably want to do it in a separate PR. Let's wait until after we resolve this one.

@michaelficarra
Copy link
Member

From editor call today:

  • let's also do tables 34, 35, and 36 as well
  • no parens is fine
  • it can all be done in this PR

@bakkot
Copy link
Contributor

bakkot commented Jun 21, 2023

Doing it for everything ends up being kind of noisy:
Screen Shot 2023-06-21 at 3 01 46 PM

But I guess I'm ok with it.

@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants