-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Replace the single-row time zone code points table #3098
base: main
Are you sure you want to change the base?
Conversation
Personally, I'd prefer to do this for tables 34 and 35 as well. |
spec.html
Outdated
@@ -32725,7 +32697,7 @@ <h2>Syntax</h2> | |||
|
|||
TemporalSign ::: | |||
ASCIISign | |||
<MINUS> | |||
<U+2212 MINUS SIGN> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but we typically parenthesise the code point name.
<U+2212 MINUS SIGN> | |
<U+2212 (MINUS SIGN)> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not consistent about the parentheses, although it's true that they are much more common than not (exceptions being concentrated in Canonicalize, plus one outlier in Appendix F).
But this particular suggestion also has the drawback that it will be rejected by the just-released version of ESMeta (which AFAICT was only extended to allow <U[+]([1-9A-F]|10)?[0-9A-F]{4}( \w+)*>
), and beyond that I'd like to get to a point where ECMA-262 and 402 hew more closely to Unicode conventions (i.e., "U+…" followed by an unpunctuated uppercase name [in small caps where possible]). Given that, is appearance inside a grammar as a nonterminal sufficient distinction for omitting the parentheses here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think either way is fine, I was just trying to match our current conventions. I'll bring it up in editor call.
d361c3a
to
50417ed
Compare
Agreed! Should I extend this PR to do so? |
50417ed
to
3042439
Compare
@gibson042 We'll probably want to do it in a separate PR. Let's wait until after we resolve this one. |
From editor call today:
|
The single-row Time Zone Offset String Code Points table takes up a large amount of visual space for little practical benefit. This PR replaces it with direct use of
<U+2212 MINUS SIGN>
in the only grammar production that references the abbreviation defined by the table.