-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Use "is a foo completion" instead of testing [[Type]] field #3163
Conversation
@bakkot: It looks like ecmarkup is confused by |
Ugh, yeah, overzealous regex. Will fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
e48ba76
to
0484aa7
Compare
(force-pushed to resolve merge conflicts) |
0484aa7
to
49472d1
Compare
49472d1
to
09cbecd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
09cbecd
to
c7560a5
Compare
Mostly, change:
_x_.[[Type]] is ~foo~
to:
_x_ is a foo completion
Resolves issue #2644.