Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Use "is a foo completion" instead of testing [[Type]] field #3163

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Sep 4, 2023

Mostly, change:
_x_.[[Type]] is ~foo~
to:
_x_ is a foo completion

Resolves issue #2644.

@jmdyck
Copy link
Collaborator Author

jmdyck commented Sep 4, 2023

@bakkot: It looks like ecmarkup is confused by
If _completion_ is a throw completion, then
and
If _completion_ is a return completion, then

@bakkot
Copy link
Contributor

bakkot commented Sep 4, 2023

Ugh, yeah, overzealous regex. Will fix.

Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmdyck
Copy link
Collaborator Author

jmdyck commented Sep 21, 2023

(force-pushed to resolve merge conflicts)

Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jan 8, 2024
tc39#3163)

Mostly, change:
    _x_.[[Type]] is ~foo~
to:
    _x_ is a foo completion

Resolves issue tc39#2644.
@ljharb ljharb merged commit c7560a5 into tc39:main Jan 10, 2024
7 checks passed
@jmdyck jmdyck deleted the is_a_foo_completion branch January 11, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change establishes editorial conventions ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants