Editorial: Fix a couple of inconsistencies #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusg
force-pushed
the
fix-inconsistencies
branch
3 times, most recently
from
1efbb5e
to
d658f31
Compare
linusg
changed the title
linusg
force-pushed
the
fix-inconsistencies
branch
2 times, most recently
from
78d907e
to
3e8b025
Compare
linusg
force-pushed
the
fix-inconsistencies
branch
from
3e8b025
to
2aea21e
Compare
michaelficarra
approved these changes
Sep 21, 2023
linusg
force-pushed
the
fix-inconsistencies
branch
from
2aea21e
to
b1c4c1c
Compare
linusg
force-pushed
the
fix-inconsistencies
branch
from
b1c4c1c
to
7de79a4
Compare
|
Rebased on latest main - is there anything preventing this from being merged? |
|
@linusg Waiting on review from another editor. |
ljharb
added
editorial change
establishes editorial conventions
editor call
bakkot
approved these changes
Dec 13, 2023
|
Backed out a couple changes the editors were less convinced of. |
linusg
force-pushed
the
fix-inconsistencies
branch
from
a32290b
to
15ad0cf
Compare
|
Fine by me, thanks for taking a look! Rebased and cleaned up the commit history a bit 👍 |
bakkot
approved these changes
Dec 14, 2023
syg
approved these changes
Feb 21, 2024
michaelficarra
added
the
ready to merge
…39#3181) [[DateValue]] is known to be either a finite integral number or NaN, so the direct NaN check that all other methods already use is sufficient.
…c39#3181) This name is already being used in functions with similar algorithms, including splice(), toReversed(), toSpliced(), unshift(), and with().
tc39#3181) The pattern of creating the property key only once when it is being used multiple times is already present in dozens of other functions.
…nc (tc39#3181) These three basically implement the same algorithm, but had minor differences in structure and variable names.
ljharb
force-pushed
the
fix-inconsistencies
branch
from
15ad0cf
to
c579bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while implementing these, details in commit messages.