Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markup: Eliminate unnecessary <emu-xref> elements #3196

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Markup: Eliminate unnecessary <emu-xref> elements #3196

merged 1 commit into from
Oct 19, 2023

Conversation

jmdyck
Copy link
Collaborator

@jmdyck jmdyck commented Oct 13, 2023 •
edited
Loading

Don't use an <emu-xref> element when ecmarkup will auto-link the text.

@jmdyck jmdyck added the markup things that change the spec rendering, but not the contents label Oct 13, 2023
@jmdyck
Copy link
Collaborator Author

jmdyck commented Oct 14, 2023

(I checked the build preview: all the affected text gets auto-linked as expected.)

michaelficarra
michaelficarra approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@michaelficarra
Copy link
Member

@bakkot I would love for ecmarkup to warn about these.

@bakkot bakkot mentioned this pull request Oct 17, 2023
Open
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Oct 17, 2023
@jmdyck @ljharb
Markup: Eliminate unnecessary <emu-xref> elements (tc39#3196)
0488c7b 
Don't use an <emu-xref> element when
ecmarkup will auto-link the text.
@ljharb ljharb merged commit 0488c7b into tc39:main Oct 19, 2023
7 checks passed
@jmdyck jmdyck deleted the emu-xref branch October 19, 2023 19:39
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
@jmdyck
Markup: Eliminate unnecessary <emu-xref> elements (tc39#3196)
6a9a263 
Don't use an <emu-xref> element when
ecmarkup will auto-link the text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
establishes editorial conventions markup things that change the spec rendering, but not the contents ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmdyck @michaelficarra @bakkot @ljharb