Normative bug fix: Fix RevalidateAtomicAccess to check against byte length #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Oct 16, 2023
syg
changed the title
bakkot
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
LGTM but possibly the description could be updated to make this clearer: for example,
This operation revalidates the index within the backing buffer for atomic operations
Otherwise it's natural to assume that the index is an index into the TA.
It might be nice to additionally rename the various "indexedPosition" aliases (in this as well as all other algorithms) to "indexInBuffer" or something - it's pretty weird to have an algorithm with both an "index" and an "indexedPosition" alias, where the first refers to an index within a TA and the second to an index within an ArrayBuffer.
syg
added
the
ready to merge
ljharb
force-pushed
the
fix-revalidateatomicaccess
branch
from
9d02032
to
4b93d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3199.
Marking this as editorial because the current spec text always fails and is obviously a bug.