Editorial: Fix parameter type of the OrdinaryCreateFromConstructor #3436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OrdinaryCreateFromConstructor, the constructor parameter is currently expected to be a constructor.
However, the following code demonstrates that a function object can also be passed as the parameter(Specifically, the problem is from the EvaluateGeneratorBody).
ESMeta log
Running ESMeta in dev branch reproduces the result below.
Since changing the type from a constructor to a function object does not introduce any breaks, I propose broadening the parameter type for now. This change would also align with GetPrototypeFromConstructor.
However, further discussion may needed because, given the current parameter names and descriptions, it is unclear whether these functions are intended to accept a function object rather than just a constructor.