Editorial: use suspended-start instead of undefined in GeneratorState initialization
#3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linusg
reviewed
Oct 8, 2024
There was a problem hiding this comment.
This is an editorial change as the internal slot is defined to be one of the enum values and never undefined in https://tc39.es/ecma262/#sec-properties-of-generator-instances. Additionally this causes an assertion failure in GeneratorStart, which also makes the fix editorial.
ljharb
changed the title
bakkot
approved these changes
Oct 23, 2024
michaelficarra
approved these changes
Oct 23, 2024
michaelficarra
added
the
ready to merge
…te initialization (tc39#3438)
ljharb
changed the title
undefined in GeneratorState initialization
ljharb
force-pushed
the
create-iterator-from-closure
branch
from
cad8ec8
to
4a0ad6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3383, we chose to use
suspended-startinstead of undefined for initializing a GeneratorState, but the changes do not include CreatorIteratorFromClosure.