Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Fix typo in FinalizationRegistry global property link id #3458

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Editorial: Fix typo in FinalizationRegistry global property link id #3458

merged 1 commit into from
Oct 31, 2024

Conversation

linusg
Copy link
Member

@linusg linusg commented Oct 21, 2024

No description provided.

@linusg linusg mentioned this pull request Oct 21, 2024
Merged
michaelficarra
michaelficarra approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, though I also don't care about IDs reading nicely. They may as well be UUIDs to me.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Oct 30, 2024
@ljharb ljharb merged commit 1cf48d1 into tc39:main Oct 31, 2024
8 checks passed
@linusg linusg deleted the finalization-registry-id branch October 31, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syg syg syg approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linusg @syg @michaelficarra @ljharb