-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ fix alpha order of terms, add script to detect problems and output all terms in alpha order #115
base: main
Are you sure you want to change the base?
Conversation
…all terms in alpha order
@@ -0,0 +1,213 @@ | |||
module.exports = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to hardcode everything here, instead of basing it on a popular common shared config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just copying my boilerplate opinionated config. I'm fine with changing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd personally prefer something minimal, and static, and largely based on something commonly used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just don't bother. There's a bunch of scripts in ecma262 and those aren't linted. Since they're almost never touched it doesn't really matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's also a viable choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 nuked the rules block
## Web compatibility/"Don't break the web" | ||
|
||
### Definition | ||
|
||
A change to JavaScript is considered "**web compatible**" if it preserves the current behavior of existing websites. If it changes the behavior of existing websites, it's considered to "**break the web**". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a) i think this diff should be done in a separate PR, and b) i'm not sure alphabetically is the best approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're not sorting the glossary, there's no reason to merge any of this
Co-authored-by: Jordan Harband <[email protected]> Co-authored-by: Kevin Gibbons <[email protected]>
next step will be incorporating the alpha verification with a new github action for status checks