Normative: avoid double construction of this value
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This has consensus. |
|
This will likely need some test changes, including perhaps https://github.com/tc39/test262/blob/88a2f0dcd1df45635ebb20004ef5e5b7038f56bc/test/built-ins/Array/fromAsync/this-constructor.js |
|
Ping @js-choi. It's been over a month. Can you merge this? I don't have the required permissions. |
|
Ping @js-choi one last time. It's been over 3 months now. If you're not available to continue championing it, I'm going to request to take over this proposal. |
|
My sincere apologies for the neglect here. I’ve merged it in. |
|
@js-choi I don't see any recent commits on |
|
Fixed, sorry. |
shannonbooth
added a commit
to shannonbooth/serenity
that referenced
this pull request
Aug 28, 2023
…truct Apply a normative fix to Array.fromAsync fixed in: tc39/proposal-array-from-async#41 This avoids a double construction when Array.fromAsync is given an array like object.
shannonbooth
added a commit
to shannonbooth/serenity
that referenced
this pull request
Aug 28, 2023
Apply a normative fix to Array.fromAsync fixed in: tc39/proposal-array-from-async#41 This avoids a double construction when Array.fromAsync is given an array like object.
This was referenced Sep 15, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35. Requires consensus.