Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

TypedArray.prototype.with should convert v up front #85

Closed
syg opened this issue May 27, 2022 · 0 comments · Fixed by #86
Closed

TypedArray.prototype.with should convert v up front #85

syg opened this issue May 27, 2022 · 0 comments · Fixed by #86

Comments

@syg
Copy link
Contributor

syg commented May 27, 2022

TypedArray#with doesn't convert the value parameter until the Set call mid-iteration in step 10.b.i here. This means that you can pass in objects like { valueOf() { detach(TA.buffer); } which perform shenanigans mid-iteration, significantly complicating implementation.

We should convert value up front a la https://tc39.es/ecma262/#sec-%typedarray%.prototype.fill

h/t @marjakh for noticing
syg added a commit to syg/proposal-change-array-by-copy that referenced this issue May 27, 2022
@syg
Convert value in TypedArray#with before the copy loop
0aad930 
Closes tc39#85
@syg syg mentioned this issue May 27, 2022
Merged
@jridgewell jridgewell mentioned this issue Jun 7, 2022
Open
@acutmore acutmore mentioned this issue Jun 8, 2022
Merged
acutmore added a commit to acutmore/proposal-change-array-by-copy that referenced this issue Jun 9, 2022
@acutmore
update spec after tc39#85 and support bigint
e95267a
@acutmore acutmore mentioned this issue Jun 9, 2022
Merged
rricard pushed a commit that referenced this issue Jun 10, 2022
Merge pull request #87 from acutmore/match-latest-spec-and-support-bi…
435df6c 
…gint

update pollyfill after #85 and support bigint
This was referenced Jun 23, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert value in TypedArray#with before the copy loop syg/proposal-change-array-by-copy
1 participant
@syg