Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References to "Unix epoch" should be replaced #2175

Closed
gibson042 opened this issue May 4, 2022 · 2 comments
Closed

References to "Unix epoch" should be replaced #2175

gibson042 opened this issue May 4, 2022 · 2 comments
Labels
documentation Additions to documentation editorial spec-text Specification text involved
Milestone

Comments

@gibson042
Copy link
Collaborator

The term is not defined, and may not even be accurate (as opposed to e.g. "POSIX epoch", referring to the definition of "Epoch" in POSIX).

But it's probably best to use a definition internal to ECMA-262, such as the one that currently exists at https://tc39.es/ecma262/multipage/numbers-and-dates.html#sec-time-values-and-time-range .

@gibson042 gibson042 added spec-text Specification text involved editorial labels May 4, 2022
@justingrant justingrant added the documentation Additions to documentation label May 5, 2022
@justingrant
Copy link
Collaborator

We also mention UNIX Epoch in the docs, so we should think about whether we want to change the docs at the same time as changing the spec.

@ptomato ptomato added this to the Stage 4 milestone Dec 8, 2022
mlemoine-clgx added a commit to mlemoine-clgx/proposal-temporal that referenced this issue Dec 8, 2022
ptomato pushed a commit that referenced this issue Dec 8, 2022
Aditi-1400 pushed a commit to Aditi-1400/proposal-temporal that referenced this issue Jan 9, 2023
@ptomato
Copy link
Collaborator

ptomato commented Mar 26, 2024

All of the occurrences in the spec text no longer mention "Unix" and now link to ECMA-262's definition of "epoch".

I'm inclined towards not changing the docs site. I think "Unix epoch" is fine for the documentation, and wherever it appears it links to the Wikipedia entry for "Unix time".

I'm assuming it's OK to close this, but feel free to reopen if you feel strongly about the docs.

@ptomato ptomato closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Additions to documentation editorial spec-text Specification text involved
Projects
None yet
Development

No branches or pull requests

3 participants