Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Use ISO Date and Date-Time Records in more places #2949

Closed
ptomato opened this issue Sep 24, 2024 · 0 comments · Fixed by #3003
Closed

Editorial: Use ISO Date and Date-Time Records in more places #2949

ptomato opened this issue Sep 24, 2024 · 0 comments · Fixed by #3003
Labels
editorial spec-text Specification text involved
Milestone
Stage "3.5"

Comments

@ptomato
Copy link
Collaborator

ptomato commented Sep 24, 2024

Similar to what we did for Duration Records in #2308, go through the spec text and replace long parameter lists of year, month, day, hour, etc. with ISO Date-Time Records or ISO Date Records.
@ptomato ptomato added spec-text Specification text involved editorial labels Sep 24, 2024
@ptomato ptomato added this to the Stage "3.5" milestone Sep 24, 2024
@ptomato ptomato mentioned this issue Sep 24, 2024
Closed
27 tasks
@anba anba mentioned this issue Sep 26, 2024
Closed
@ptomato ptomato mentioned this issue Oct 7, 2024
Closed
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date(-Time) Record in ISODate(Time)WithinLimits
29d9355 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date Record in CompareISODate and ISODateSurpasses
74f754e 
In CompareISODate, use two ISO Date Records instead of passing each
component individually. In ISODateSurpasses, the first date does not have
to exist, so rewrite the operation without using CompareISODate and only
take an ISO Date Record for the second parameter.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use Time Record in DifferenceTime
a607493 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use Time Record in TemporalTimeToString, and rename
a8c0664 
Instead of passing each component individually, pass a Time Record. The
name is no longer really appropriate, since we are not passing a Temporal
object, so rename it to TimeRecordToString.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use Time Record in CompareTemporalTime, and rename
bee282b 
Instead of passing each component individually, pass Time Records. The
name is no longer really appropriate, since we are not passing a Temporal
object, so rename it to CompareTimeRecord.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use Time Record in AddTime
a6ec4bb 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date-Time Record in RoundISODateTime
46faf71 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use Time Record in RoundTime
8d093f0 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date-Time Record in TemporalDateTimeToString, and …
ab865d2 
…rename

Instead of passing each component individually, pass an ISO Date-Time
Record. The name is no longer really appropriate, since we are not passing
a Temporal object, so rename it to ISODateTimeToString.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Compose ISO Date-Time Record of ISO Date Record and Time R…
f91a867 
…ecord

Instead of individual fields, give ISO Date-Time Record just two fields,
[[ISODate]] and [[Time]]. Since we are passing ISO Date and Time Records
in more places, this is better for readability.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date-Time Record in CompareISODateTime
648d8ef 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date-Time Record in DifferenceISODateTime
116bc35 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date-Time Record in DifferencePlainDateTimeWithRou…
955a106 
…nding

Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date-Time Record in DifferencePlainDateTimeWithTotal
9aea7ad 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date Record in InterpretISODateTimeOffset
4c9352c 
Instead of passing each component individually.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date Record in ISOYearMonthWithinLimits
8fa2c40 
Instead of passing each component individually.

The [[Day]] field is ignored.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date-Time Record in GetUTCEpochNanoseconds
ba45dde 
Instead of passing each component individually. GetUTCEpochNanoseconds is
part of ECMA-262 already, so this requires some <ins> and <del> tags.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use ISO Date-Time Record in GetNamedTimeZoneEpochNanoseconds
73a0db4 
Instead of passing each component individually.
GetNamedTimeZoneEpochNanoseconds is part of ECMA-262 already, so this
requires some <ins> and <del> tags.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Add MidnightTimeRecord and NoonTimeRecord
95fc496 
These are repeated several times now throughout the spec, so abstract them
out for readability.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Use records in internal slots of Temporal objects
d3580cf 
For PlainDate, PlainYearMonth, and PlainMonthDay, use an ISO Date Record
in the [[ISODate]] internal slot. For PlainDateTime, use an ISO Date-Time
Record in the [[ISODateTime]] internal slot. For PlainTime, use a Time
Record in the [[Time]] internal slot.

This makes a lot more concise spec text, and probably corresponds better
with how it will be implemented.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Add CreateTimeRecord AO
84edd2e 
Instead of writing out all the field names, add an abstract operation that
also encapsulates the IsValidTime assertion.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Inline ConstrainTime into RegulateTime
d591ca8 
This is the only place it's called from, and it consolidates operations
that take individual time components.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Return ISO Date-Time Record from SystemDateTime
caa3c91 
This avoids creation of an unobservable Temporal.PlainDateTime object, and
is also simpler to read.

See: #2949
ptomato added a commit that referenced this issue Oct 8, 2024
@ptomato
Editorial: Inline SystemInstant and SystemZonedDateTime
1fccaf7 
This fits with the general theme of returning Records instead of Objects,
but also these operations were each only called from one place. So inline
them.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Inline ConstrainTime into RegulateTime
1fcb24d 
This is the only place it's called from, and it consolidates operations
that take individual time components.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Return ISO Date-Time Record from SystemDateTime
1eb5ab7 
This avoids creation of an unobservable Temporal.PlainDateTime object, and
is also simpler to read.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Inline SystemInstant and SystemZonedDateTime
e76e417 
This fits with the general theme of returning Records instead of Objects,
but also these operations were each only called from one place. So inline
them.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date Records in ToISOWeekOfYear/DayOfYear/DayOfWeek
3490b8f 
Instead of passing each component individually. Also, remove the "To" from
the name, as it's not a conversion operation.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date(-Time) Record in ISODate(Time)WithinLimits
7d3fe71 
Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date Record in CompareISODate and ISODateSurpasses
184cc33 
In CompareISODate, use two ISO Date Records instead of passing each
component individually. In ISODateSurpasses, the first date does not have
to exist, so rewrite the operation without using CompareISODate and only
take an ISO Date Record for the second parameter.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use Time Record in DifferenceTime
a27ab89 
Instead of passing each component individually.

See: #2949
Ms2ger added a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use Time Record in TemporalTimeToString, and rename
218ff5a 
Instead of passing each component individually, pass a Time Record. The
name is no longer really appropriate, since we are not passing a Temporal
object, so rename it to TimeRecordToString.

See: #2949

Co-authored-by: Ms2ger <[email protected]>
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use Time Record in CompareTemporalTime, and rename
2d10744 
Instead of passing each component individually, pass Time Records. The
name is no longer really appropriate, since we are not passing a Temporal
object, so rename it to CompareTimeRecord.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use Time Record in AddTime
535cbac 
Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date-Time Record in RoundISODateTime
2cd4372 
Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use Time Record in RoundTime
45f82f9 
Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date-Time Record in TemporalDateTimeToString, and …
991d882 
…rename

Instead of passing each component individually, pass an ISO Date-Time
Record. The name is no longer really appropriate, since we are not passing
a Temporal object, so rename it to ISODateTimeToString.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Compose ISO Date-Time Record of ISO Date Record and Time R…
a11d31c 
…ecord

Instead of individual fields, give ISO Date-Time Record just two fields,
[[ISODate]] and [[Time]]. Since we are passing ISO Date and Time Records
in more places, this is better for readability.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date-Time Record in CompareISODateTime
aa3a36e 
Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date-Time Record in DifferenceISODateTime
57350a3 
Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date-Time Record in DifferencePlainDateTimeWithRou…
1452c09 
…nding

Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date-Time Record in DifferencePlainDateTimeWithTotal
02f8c43 
Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date Record in InterpretISODateTimeOffset
5396508 
Instead of passing each component individually.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date Record in ISOYearMonthWithinLimits
9e80104 
Instead of passing each component individually.

The [[Day]] field is ignored.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date-Time Record in GetUTCEpochNanoseconds
e948cc8 
Instead of passing each component individually. GetUTCEpochNanoseconds is
part of ECMA-262 already, so this requires some <ins> and <del> tags.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date-Time Record in GetNamedTimeZoneEpochNanoseconds
8e57e86 
Instead of passing each component individually.
GetNamedTimeZoneEpochNanoseconds is part of ECMA-262 already, so this
requires some <ins> and <del> tags.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Add MidnightTimeRecord and NoonTimeRecord
1e06584 
These are repeated several times now throughout the spec, so abstract them
out for readability.

See: #2949
Ms2ger added a commit that referenced this issue Oct 8, 2024
@ptomato @justingrant @Ms2ger
Editorial: Use records in internal slots of Temporal objects
86ff110 
For PlainDate, PlainYearMonth, and PlainMonthDay, use an ISO Date Record
in the [[ISODate]] internal slot. For PlainDateTime, use an ISO Date-Time
Record in the [[ISODateTime]] internal slot. For PlainTime, use a Time
Record in the [[Time]] internal slot.

This makes a lot more concise spec text, and probably corresponds better
with how it will be implemented.

See: #2949

Co-authored-by: Justin Grant <[email protected]>
Co-authored-by: Ms2ger <[email protected]>
Ms2ger added a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Add CreateTimeRecord AO
607e263 
Instead of writing out all the field names, add an abstract operation that
also encapsulates the IsValidTime assertion.

See: #2949

Co-authored-by: Ms2ger <[email protected]>
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Inline ConstrainTime into RegulateTime
abb2f2c 
This is the only place it's called from, and it consolidates operations
that take individual time components.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Return ISO Date-Time Record from SystemDateTime
1a23f2c 
This avoids creation of an unobservable Temporal.PlainDateTime object, and
is also simpler to read.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Inline SystemInstant and SystemZonedDateTime
aebfa3c 
This fits with the general theme of returning Records instead of Objects,
but also these operations were each only called from one place. So inline
them.

See: #2949
Ms2ger pushed a commit that referenced this issue Oct 8, 2024
@ptomato @Ms2ger
Editorial: Use ISO Date Records in ToISOWeekOfYear/DayOfYear/DayOfWeek
cb2e0ff 
Instead of passing each component individually. Also, remove the "To" from
the name, as it's not a conversion operation.

See: #2949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
Stage "3.5"
Development

Successfully merging a pull request may close this issue.

Editorial: Use ISO Date, ISO Date-Time, and Time Records in more places tc39/proposal-temporal
1 participant
@ptomato