Normative: Don't accept Z designators in strings for Plain types #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1874 +/- ##
=======================================
Coverage 95.01% 95.02%
=======================================
Files 19 19
Lines 10940 10949 +9
Branches 1732 1739 +7
=======================================
+ Hits 10395 10404 +9
Misses 530 530
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Draft until presented at TC39 |
justingrant
approved these changes
Oct 15, 2021
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Oct 19, 2021
(Needs more complete test coverage.) Tests for the normative changes made to Temporal in tc39/proposal-temporal#1874
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Oct 23, 2021
(Needs more complete test coverage.) Tests for the normative changes made to Temporal in tc39/proposal-temporal#1874
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Oct 26, 2021
(Needs more complete test coverage.) Tests for the normative changes made to Temporal in tc39/proposal-temporal#1874
|
This gained consensus at the October TC39 plenary. I am currently working on updating the tests. |
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Nov 1, 2021
(Needs more complete test coverage.) Tests for the normative changes made to Temporal in tc39/proposal-temporal#1874
ptomato
force-pushed
the
1751-plaindate-z-strings
branch
2 times, most recently
from
9556bca
to
cccb5a3
Compare
|
This change unearthed that we have some really out of date cookbook examples Maybe we can get #1930 in first and then land this one. |
Accepting this kind of string in Plain types poses a risk when deserializing from databases, as some attach local-time-zone semantics to this kind of string. This could cause user-facing off-by-one-day bugs. Closes: #1751
ptomato
force-pushed
the
1751-plaindate-z-strings
branch
from
cccb5a3
to
efe75c0
Compare
justingrant
added a commit
to justingrant/proposal-temporal
that referenced
this pull request
Nov 24, 2021
In tc39#1874, we removed the ability to parse Z strings with Plain types' `from` methods. This PR explains this change and documents workarounds. The docs for PlainYearMonth and PlainMonthDay (where Z strings are rare) get only minimal text. PlainDate, PlainDateTime, and PlainTime (where Z-string use cases are most likely) get a little more explanation and a short code sample.
|
Cool! I opened #1942 to describe these changes in the docs. |
ptomato
pushed a commit
that referenced
this pull request
Nov 24, 2021
In #1874, we removed the ability to parse Z strings with Plain types' `from` methods. This PR explains this change and documents workarounds. The docs for PlainYearMonth and PlainMonthDay (where Z strings are rare) get only minimal text. PlainDate, PlainDateTime, and PlainTime (where Z-string use cases are most likely) get a little more explanation and a short code sample.
12wrigja
added a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Nov 30, 2021
Co-authored-by: Philip Chimento <[email protected]>
ptomato
added a commit
that referenced
this pull request
Dec 3, 2021
Since #1874, strings with Z UTC designator are disallowed for Plain types. This was not yet reflected in the manual ISO string generator test.
Ms2ger
pushed a commit
that referenced
this pull request
Dec 3, 2021
Since #1874, strings with Z UTC designator are disallowed for Plain types. This was not yet reflected in the manual ISO string generator test.
ptomato
added a commit
to ptomato/test262
that referenced
this pull request
Dec 10, 2021
Tests for the normative changes made to Temporal in tc39/proposal-temporal#1874
This was referenced Dec 12, 2021
rwaldron
pushed a commit
to tc39/test262
that referenced
this pull request
Dec 14, 2021
Tests for the normative changes made to Temporal in tc39/proposal-temporal#1874
This was referenced Jan 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepting this kind of string in Plain types poses a risk when
deserializing from databases, as some attach local-time-zone semantics to
this kind of string. This could cause user-facing off-by-one-day bugs.
(Note: this could probably be refactored to have these strings actually be invalid according to the ISO 8601 grammar, but this PR is set up so that could be done separately as an editorial change.)
Closes: #1751