Remove conditional lookups #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2726 +/- ##
==========================================
+ Coverage 96.38% 96.39% +0.01%
==========================================
Files 21 21
Lines 12615 12497 -118
Branches 2356 2262 -94
==========================================
- Hits 12159 12047 -112
+ Misses 401 395 -6
Partials 55 55 ☔ View full report in Codecov by Sentry. |
gibson042
approved these changes
Nov 11, 2023
|
@gibson042 Would you be able to check if you agree with tc39/test262#3959 as well, so we can get this merged promptly? |
gibson042
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
@gibson042 Would you be able to check if you agree with tc39/test262#3959 as well, so we can get this merged promptly?
Done.
In several Temporal.Duration operations we create a Calendar Methods Record from zonedRelativeTo.[[Calendar]] if relativeTo is a ZonedDateTime, otherwise from plainRelativeTo.[[Calendar]] if relativeTo is a PlainDate, and otherwise we don't use a Calendar Methods Record. This abstracts that process into a new AO.
ptomato
force-pushed
the
2724-remove-conditional-lookups
branch
from
966a673
to
a19b982
Compare
|
Thanks for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Richard's comments on #2519.
Tests are in tc39/test262#3959
Closes: #2724