Editorial: Next batch of minor editorial improvements #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ptomato
commented
May 14, 2024
ptomato
commented
- After Normative: Fix Duration rounding relative to ZonedDateTime #2758, there is only one remaining caller of AddDuration. Inlining it into its caller makes it easier to implement / understand.
- Closes BalanceTimeDuration: CreateTimeDurationRecord can create too large duration values #2785 by making BalanceTimeDuration return a completion record, as @anba pointed out there are circumstances in which it can fail.
- Fix broken ESIDs
- Comparing numbers uses =, not "is"
After combining the diffing and rounding code paths, this is the only remaining caller of AddDuration. Additionally, rename it to AddDurations to avoid the unwieldy name.
GetNamedTimeZoneNextTransition and GetNamedTimeZonePreviousTransition had the wrong ESIDs.
Commit 1643cc6 only changed IsValidDuration to correctly reject too-large duration values, but the other half was that BalanceTimeDuration needs to be able to throw when that happens. BalanceTimeDuration can throw due to floating-point rounding error if the normalized time duration could be nearby the limit and largestUnit is milliseconds, microseconds, or nanoseconds. Closes: #2785
Ms2ger
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.