This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Revert "Move constructors to the System object" #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Block on resolving #22 |
|
For reasons stated at #22 (comment) , we now agree that #22 can be closed and this PR merged. |
|
Merging this PR per #96 (comment) , but I am leaving #22 open for a bit of continued discussion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #67
There are other mechanisms possible to make it easier to maintain certain virtualization shims, discussed in #22. This mechanism could be part of this proposal, part of another proposal, or implemented in JavaScript (as it is today). In any case, this mechanism could make it not longer needed to use the
Systemobject for the WeakRef and FinalizationGroup objects.