Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESMeta CI job is failing #4267

Closed
ptomato opened this issue Oct 15, 2024 · 5 comments · Fixed by #4270
Closed

ESMeta CI job is failing #4267

ptomato opened this issue Oct 15, 2024 · 5 comments · Fixed by #4270

Comments

@ptomato
Copy link
Contributor

ptomato commented Oct 15, 2024

Since a couple of days ago, the ESMeta CI job is failing because it cannot locate the sbt binary.

@ptomato
Copy link
Contributor Author

ptomato commented Oct 15, 2024

cc @doehyunbaek @jhnaldo - any idea what is happening?

@ptomato
Copy link
Contributor Author

ptomato commented Oct 15, 2024

@jhnaldo
Copy link
Contributor

jhnaldo commented Oct 15, 2024

Thanks for letting me know the problem.

See actions/runner-images#10788 and actions/runner-images#10636

This issue seems the main reason for the problem.

Should we wait until this issue is resolved in actions, or should we try to resolve this issue now?

ptomato added a commit to ptomato/test262 that referenced this issue Oct 15, 2024
One of the core developers of SBT has kindly created an action to replace
the missing SBT in newer Ubuntu images.
https://github.com/marketplace/actions/setup-sbt-installer

Closes: tc39#4267
@ljharb
Copy link
Member

ljharb commented Oct 15, 2024

What would probably be wisest is to add a step to https://github.com/tc39/test262/blob/main/.github/workflows/esmeta-test262.yml (and https://github.com/tc39/ecma262/blob/main/.github/workflows/esmeta-typecheck.yml) that installs sbt, that's skipped if it's already present. That way, if github fixes it, the job will be faster, but it'll work regardless.

Additionally, it'd probably be good to create a single esmeta action that both of these workflows can use, so that there's only one place needed to change for stuff like this.

@ptomato
Copy link
Contributor Author

ptomato commented Oct 16, 2024

#4270 should fix it. It doesn't skip installing SBT if already present, but I think it's pretty unlikely that GitHub would re-add it, given that people have been complaining for three weeks already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants