Temporal: Test new limits for getOffsetNanosecondsFor #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for some tests to ensure that they are testing the right exception, we need to make sure we are in the path where there are no possible instants for a particular date-time. Override this method in some tests.
This adds tests that validate a user-callable getOffsetNanosecondsFor to several APIs that didn't test this yet: ZonedDateTime.since/until, and Calendar.era/eraYear.
…ndsFor This tests the normative change from tc39/proposal-temporal#2260 which achieved consensus in the July 2022 TC39 meeting. The return value from a userland getOffsetNanosecondsFor method is no longer allowed to be exactly one 24-hour day.
Aditi-1400
approved these changes
Sep 16, 2022
Ms2ger
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the normative change from tc39/proposal-temporal#2260 which achieved consensus in the July 2022 TC39 meeting. The PR is mostly subtracting 1 from a number of nanoseconds 😛 but there are two other commits that bring some similar tests more in line with each other.