Round epoch time getters towards negative infinity #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
approved these changes
Apr 8, 2023
ptomato
added a commit
to tc39/proposal-temporal
that referenced
this pull request
Apr 8, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0).
Update tests to match <tc39/proposal-temporal#2424>.
Ms2ger
force-pushed
the
round-towards-neg-inf
branch
from
94f00f5
to
1e6409a
Compare
ptomato
added a commit
to tc39/proposal-temporal
that referenced
this pull request
Apr 10, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0).
ptomato
added a commit
to tc39/proposal-temporal
that referenced
this pull request
Apr 10, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0).
justingrant
pushed a commit
to tc39/proposal-temporal
that referenced
this pull request
Apr 20, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0). UPSTREAM_COMMIT=6e0ad2030170540084a4a400005cc2bc8c791bdb
justingrant
pushed a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Apr 25, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0). UPSTREAM_COMMIT=6e0ad2030170540084a4a400005cc2bc8c791bdb
justingrant
pushed a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Apr 25, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0). UPSTREAM_COMMIT=6e0ad2030170540084a4a400005cc2bc8c791bdb
justingrant
pushed a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Apr 25, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0). UPSTREAM_COMMIT=6e0ad2030170540084a4a400005cc2bc8c791bdb
justingrant
pushed a commit
to justingrant/temporal-polyfill
that referenced
this pull request
Apr 26, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0). UPSTREAM_COMMIT=6e0ad2030170540084a4a400005cc2bc8c791bdb
justingrant
pushed a commit
to js-temporal/temporal-polyfill
that referenced
this pull request
Apr 26, 2023
See #2423 for the issue and #2424 for the spec text change, which was already adopted some time ago. I thought the reference code already worked like this, but it does not. Anba pointed this out in tc39/test262#3802 and provided correct test262 tests for the feature. Note that the big-integer library doesn't have a floor division function. We roll our own. If the divisor or dividend is negative (but not both) and there is a remainder, then we subtract 1 from the result (round towards negative infinity instead of 0). UPSTREAM_COMMIT=6e0ad2030170540084a4a400005cc2bc8c791bdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests to match tc39/proposal-temporal#2424.