Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all tests using import assertions to files named as such #3872

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 17, 2023

Extracted from #3843. I need this commit as a common base for two PR:

  • add import attributes tests
  • update import assertions tests after the recent normative changes (in the past 6 months)

@nicolo-ribaudo nicolo-ribaudo requested a review from a team as a code owner July 17, 2023 10:58
@nicolo-ribaudo
Copy link
Member Author

CI is failing because gralljs 23 changed the name of their release artifacts (now the folder is prefixed as graal-23.0.0 and not vm-23.0.0), and esvu does not support it yet.

https://github.com/oracle/graaljs/releases/tag/graal-23.0.0

@linusg
Copy link
Member

linusg commented Jul 17, 2023

GraalJS should not even run as part of CI anymore (a858077), you might need to rebase the PR

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a question about some of the tests that look like they would be common to both import assertions and import attributes, such as the trailing comma in import('foo',). @nicolo-ribaudo explained to me that we'll get duplicate tests for these (1) because they are generated anyway and (2) because there is no way to express "import-assertions OR import-attributes" in the feature flags.

Since this is blocking other PRs, I'll go ahead and merge it.

@ptomato ptomato merged commit 7ef1833 into tc39:main Jul 17, 2023
1 check passed
@nicolo-ribaudo nicolo-ribaudo deleted the import-assertions-move branch July 17, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants