Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal: Audit of user code calls, part 3 #3923

Merged
merged 9 commits into from
Oct 4, 2023
Merged

Temporal: Audit of user code calls, part 3 #3923

merged 9 commits into from
Oct 4, 2023

Commits on Oct 4, 2023

  1. Temporal: Avoid calendar operations when adding days-only duration to… 

    … ZDT

This allows removing several tests, as calendar.dateAdd() is no longer
called in several places, and it's no longer possible to create a
situation where BigInt arithmetic is observable in NanosecondsToDays.
    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    ca3b1c0 View commit details
    Browse the repository at this point in the history

  2. Temporal: Fast-path AddDaysToZonedDateTime in AddZonedDateTime

    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d0790ed View commit details
    Browse the repository at this point in the history

  3. Temporal: Avoid calendar operations when adding days-only duration to… 

    … PlainDate
    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    5f3d923 View commit details
    Browse the repository at this point in the history

  4. Temporal: Fast-path dateAdd() when adding only days

    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6c38171 View commit details
    Browse the repository at this point in the history

  5. Temporal: Fast-path differences between identical objects

    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    6b0bea9 View commit details
    Browse the repository at this point in the history

  6. Temporal: Fast-path dateUntil() when difference largest unit is days 

    This removes several loopholes where it was possible to return particular
values from user calls that would cause infinite loops, or calculate
zero-length days.
    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    bc1ba1a View commit details
    Browse the repository at this point in the history

  7. Temporal: Look up getOffsetNanosecondsFor only once when resolving am… 

    …biguous datetime
    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    4411326 View commit details
    Browse the repository at this point in the history

  8. Temporal: Precalculate PlainDateTime from ZonedDateTime in more places

    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    37b6fe3 View commit details
    Browse the repository at this point in the history

  9. Temporal: Tests for absolute value bug in duration rounding no-op con… 

    …ditions

Repeat all the existing tests for no-op duration rounding operations, but
with negative durations.
    @ptomato
    ptomato committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d26e3eb View commit details
    Browse the repository at this point in the history