Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal: Move tests for ZonedDateTime/p/{since, until} out of staging #4293

Merged

Conversation

catamorphism
Copy link
Contributor

No description provided.

@catamorphism catamorphism requested review from a team as code owners October 29, 2024 23:11
@catamorphism catamorphism force-pushed the move-temporal-zoneddatetime-since-tests branch from ab77bbb to 0fc2b60 Compare October 29, 2024 23:20
@catamorphism catamorphism changed the title Temporal: Move tests for ZonedDateTime/p/since out of staging Temporal: Move tests for ZonedDateTime/p/{since, until} out of staging Oct 31, 2024
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor comments, otherwise ready to merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably give this one a longer list of epoch nanoseconds values and test each pair in the list, but that's out of scope for this PR. I'll add it to the list of follow-ups.

@catamorphism catamorphism force-pushed the move-temporal-zoneddatetime-since-tests branch from 3a430cb to beb8089 Compare November 1, 2024 17:59
@catamorphism catamorphism merged commit b7822bb into tc39:main Nov 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants