-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporal: Move tests for ZonedDateTime/p/{since, until} out of staging #4293
Temporal: Move tests for ZonedDateTime/p/{since, until} out of staging #4293
Conversation
ab77bbb
to
0fc2b60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some minor comments, otherwise ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably give this one a longer list of epoch nanoseconds values and test each pair in the list, but that's out of scope for this PR. I'll add it to the list of follow-ups.
test/built-ins/Temporal/ZonedDateTime/prototype/since/casts-argument.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/ZonedDateTime/prototype/since/returns-hours-by-default.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/ZonedDateTime/prototype/since/returns-hours-by-default.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/ZonedDateTime/prototype/since/can-return-lower-or-higher-units.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/ZonedDateTime/prototype/since/rounding-increments.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/ZonedDateTime/prototype/since/valid-rounding-increments.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/ZonedDateTime/prototype/until/invalid-increments.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/ZonedDateTime/prototype/until/valid-increments.js
Outdated
Show resolved
Hide resolved
test/built-ins/Temporal/ZonedDateTime/prototype/since/rounds-relative-to-receiver.js
Outdated
Show resolved
Hide resolved
…ing into separate files under test/built-ins
…gument.js Co-authored-by: Philip Chimento <[email protected]>
…-include-higher-units-than-necessary.js Co-authored-by: Philip Chimento <[email protected]>
3a430cb
to
beb8089
Compare
No description provided.