-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added find_if and find_if_not tests #212
Conversation
Hi! This is my first time attempting to contribute to a project on GitHub so if I'm doing anything wrong please let me know! I followed some instructions I found online for submitting a pull request, and I'm not actually confident that I did it right, so if there is a better process I'd love to get a quick walkthrough. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 98.61% 98.62%
=======================================
Files 69 69
Lines 2608 2614 +6
=======================================
+ Hits 2572 2578 +6
Misses 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very comprehensive, thank you! Just a couple of little comments -- the function statically testing find_if_not()
should be called test_find_if_not()
, and we want to run the static test functions at runtime as well.
Other than that, this looks great!
Thanks! I fixed the naming and added the runtime tests. |
Merged, thank you very much @nwad123! |
Resolves #194