Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added find_if and find_if_not tests #212

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

nwad123
Copy link
Contributor

@nwad123 nwad123 commented Nov 4, 2024

Resolves #194

@nwad123
Copy link
Contributor Author

nwad123 commented Nov 4, 2024

Hi! This is my first time attempting to contribute to a project on GitHub so if I'm doing anything wrong please let me know! I followed some instructions I found online for submitting a pull request, and I'm not actually confident that I did it right, so if there is a better process I'd love to get a quick walkthrough.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (b07090f) to head (a0459ac).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   98.61%   98.62%           
=======================================
  Files          69       69           
  Lines        2608     2614    +6     
=======================================
+ Hits         2572     2578    +6     
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@tcbrindle tcbrindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very comprehensive, thank you! Just a couple of little comments -- the function statically testing find_if_not() should be called test_find_if_not(), and we want to run the static test functions at runtime as well.

Other than that, this looks great!

test/test_find_if_not.cpp Outdated Show resolved Hide resolved
test/test_find_if_not.cpp Outdated Show resolved Hide resolved
test/test_find_if.cpp Show resolved Hide resolved
test/test_find_if_not.cpp Show resolved Hide resolved
@nwad123
Copy link
Contributor Author

nwad123 commented Nov 5, 2024

Thanks! I fixed the naming and added the runtime tests.

@tcbrindle tcbrindle merged commit 465d55f into tcbrindle:main Nov 5, 2024
47 checks passed
@tcbrindle
Copy link
Owner

Merged, thank you very much @nwad123!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add find_if tests
2 participants