Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pill background color when the user is mentioned #1076

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Jun 25, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

#1075

Screenshots / GIFs

Before After
image image

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle self-assigned this Jun 25, 2024
@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against bbad78f

Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, mais ne faudrait-il pas aussi traiter la pill présente dans une citation (celle en rouge dans les captures) ?

@yostyle
Copy link
Contributor Author

yostyle commented Jun 25, 2024

Ok, mais ne faudrait-il pas aussi traiter la pill présente dans une citation (celle en rouge dans les captures) ?

c'est une image iOS dans la capture android

@yostyle yostyle merged commit 95b4743 into develop Jun 25, 2024
15 of 16 checks passed
@yostyle yostyle deleted the yostyle/mention_style branch June 25, 2024 16:07
@areox-net
Copy link
Collaborator

areox-net commented Jun 26, 2024

Merci @yostyle ,
as tu aussi pris en compte la dernière ligne du PDF, quand on repond à l'user sans le mentionner dans le texte ? Dans ce cas on colore le text en bleu et on augmente la graisse:

Screenshot 2024-06-26 at 09 39 58

@areox-net
Copy link
Collaborator

@yostyle Tu peux ignorer mon commentaire précedent. La pastille bleue suffit ur mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants