Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSO connection #1100

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Enable SSO connection #1100

wants to merge 6 commits into from

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Aug 6, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

#1104
#1115
tchapgouv/tchap-product#195

Screenshots / GIFs

Feature flag disabled Feature flag enabled
No email Email match

Create account

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle self-assigned this Aug 6, 2024
@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against f449d83

Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is GetPlatformResult.Failure -> {
// Nothin to do.
}

// Nothin to do --> // Nothing to do (typo)

Copy link

gitguardian bot commented Sep 16, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 dangerJS against 4656116

@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 dangerJS against 48eb05f

@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 dangerJS against 1dd46d3

@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 dangerJS against 8b1476a

@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 dangerJS against aa4753b

@yostyle yostyle marked this pull request as ready for review September 19, 2024 05:31
@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against d2e5e94

@tchap-danger-bot
Copy link

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 dangerJS against de5cbd7

@areox-net
Copy link
Collaborator

Merci @yostyle, ça me parait bien.
Pour le bouton état grisé, on ne peut pas appliquer une opacité 50% sur tout le bouton (fond, texte et image) plutot que juste changer la couleur?

@tchap-danger-bot
Copy link

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 dangerJS against 9ac810e

@yostyle
Copy link
Contributor Author

yostyle commented Oct 29, 2024

@odelcroi
#1115
#1104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants