-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement forgot password for element-web 1.11.17 #373
Reimplement forgot password for element-web 1.11.17 #373
Conversation
It would be great to take into account this twin PR comment : #369 (comment) |
Text changes, non blockers but annoying
|
Not needed any more with new flow, the two texts are on different pages now. |
With this change, I think we should remove the warning text from the backend template completely.
|
Going back to draft : I will fix the security regression in this PR, and resolve conflicts with the parent branch, and then it will be ready for review again. |
…v1.11.17-reimplement-forgot-password
Done ! |
Wording has slighty changed indeed, non blocker can be fixed after. @Caroline-lawson what do you think? |
logout tested on :
|
Filed an issue for the text changes @Caroline-lawson : #384 |
Forgot password flow was changed a lot. The code is cleaner and the interface is easier to understand. But it caused a major patch break.
This PR reimplements the patch.
----
---
---
---
---
---
---