Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a help tab in menu to redirect to external tchap faq #452

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

aulamber
Copy link
Contributor

@aulamber aulamber commented Mar 3, 2023

Cf. #395

Add a tab Help which on click open a new tab in window with the FAQ.

Screenshot 2023-03-03 at 14 07 29

@aulamber aulamber requested a review from odelcroi March 3, 2023 13:07
};

+ private onOpenFAQPage = () => {
+ window.open("https://tchap.beta.gouv.fr/faq", '_blank');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aulamber aulamber requested a review from jdauphant March 6, 2023 15:56
@aulamber aulamber closed this Mar 6, 2023
@aulamber aulamber reopened this Mar 6, 2023
};

+ private onOpenFAQPage = () => {
+ window.open("https://tchap.beta.gouv.fr/faq", '_blank');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
+ window.open("https://tchap.beta.gouv.fr/faq", '_blank');
+ window.open("https://www.tchap.gouv.fr/faq", '_blank');

Copy link
Contributor

@jdauphant jdauphant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le lien de la FAQ a corrigé et on peut merger ensuite

@aulamber aulamber merged commit 44182cb into develop_tchap Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants