Improve event handling in async stream #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous changes were made to the async command to allow that to handle read timeouts better, and to correctly wrap all of the httpx exception types. Not all of these changes were correctly applied to the async stream command as well. This change correctly sets this error handling for all async commands. This has been tested for both normal and streaming async commands to ensure the proper wrapped exception type is applied in all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous changes were made to the async command to allow that to handle
read timeouts better, and to correctly wrap all of the httpx exception
types. Not all of these changes were correctly applied to the async
stream command as well. This change correctly sets this error handling
for all async commands. This has been tested for both normal and
streaming async commands to ensure the proper wrapped exception type is
applied in all cases.