Create initial api for CRUD actions on DB #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… between an ExerciseCategory and Exercise
…y exercises that use it
|
Created issue #4 to track the refactoring of this code and ideas. However I am happy for now with it as I just wanted to get a working version complete which I can then iterate on as I learn more about ASP.NET Core 1.0. Will close PR once I have had a chance to throughly test. |
tdshipley
changed the title
| @@ -0,0 +1,45 @@ | |||
| { | |||
There was a problem hiding this comment.
This can be deleted - debugging in VSCode for ASP.NET Core 1.0 apps isn't supported yet and will be brought in by a plugin.
See microsoft/vscode#275 and https://blogs.msdn.microsoft.com/visualstudioalm/2016/03/10/experimental-net-core-debugging-in-vs-code/
| [HttpPost] | ||
| [Route("{id}")] | ||
| public JsonResult Update(int id, [FromBody] ExerciseViewModel model) | ||
| { |
There was a problem hiding this comment.
Add null check for model
SummaryMostly just need to rename things to make the code clearer. Should also:
|
|
Tested locally and all works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #2
Created the api to handle CRUD actions on the DB using EF7. Not the most efficient solution; could use automapper for example to handle the conversion of model <---> view model, EF code is not efficient but works.