Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-AMENDMENT_[]_STANDARDIZED source authorities #185

Closed
tucotuco opened this issue Apr 13, 2020 · 11 comments
Closed

TG2-AMENDMENT_[]_STANDARDIZED source authorities #185

tucotuco opened this issue Apr 13, 2020 · 11 comments

Comments

@tucotuco
Copy link
Member

tucotuco commented Apr 13, 2020

While reviewing Issue #60 on standardizing geodeticDatum I discovered that we have at least three other AMENDMENT tests that refer to a controlled vocabulary for the source authority and not to the thesaurus that will be needed to resolve them to the controlled vocabulary. The three issues are 
Issue #41 (AMENDMENT_DCTYPE_STANDARDIZED) Issue #48 (AMENDMENT_COUNTRYCODE_STANDARDIZED) and Issue #133 (AMENDMENT_LICENSE_STANDARDIZED). There may be others. The source authority for each of these will be the GBIF thesauri, but we don't have a way to refer to them yet. In Issue #60 I used the pattern "[bdq:sourceAuthority = GBIF [unqualified term name] thesaurus, when available]" in the Notes. We should reach a consensus and do the same for all affected tests.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 13, 2020

I totally agree @tucotuco. It had taken me a while to understand we needed vocabs for validations and thesauri for a subset of the 28 amendments.

The template "bdq:sourceAuthority = GBIF [unqualified term name] thesaurus, when available" seems appropriate, if GBIF are committed. Given they have the most extensive record base on which to base look-ups/translations, this seems logical.

@ArthurChapman
Copy link
Collaborator

Sounds like a good plan @tucotuco. We are depending on the development and availability of the GBIF thesauri, but it is an advance on what we have now. It would be good to have @timrobertson100 or GBIF make available some documented plans on the extent and timetable for their proposed thesauri.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 13, 2020

In looking through the amendments, we use phrases inconsistently when referring to how the amendments are made: "changed to"; "converted from"; "interpreted from"; "determined from"; "added from"; "FILLED_IN from"; "standardized using"; "populated from". These do however provide some classification of amendment types.

In some cases, we reject anything but exact matches. In other cases we presume code will enable conversions. In other cases, we presume a thesaurus of some type. We need to standardize the phrasing so that it is clear what type of operation is being used.

The amendments that IMPLY some form of conversion/translation are #60, #41, #48, #133, #163, #115, #63, #45, #26, #127, #43(?), #52, #61, #86, #128, #55, #68, #32

@ArthurChapman
Copy link
Collaborator

I generally have no problem with most of these:

  1. TG2-AMENDMENT_GEODETICDATUM_STANDARDIZED #60, TG2-AMENDMENT_DCTYPE_STANDARDIZED #41, TG2-AMENDMENT_COUNTRYCODE_STANDARDIZED #48, TG2-AMENDMENT_LICENSE_STANDARDIZED #133, TG2-AMENDMENT_TAXONRANK_STANDARDIZED #163, TG2-AMENDMENT_OCCURRENCESTATUS_STANDARDIZED #115, TG2-AMENDMENT_BASISOFRECORD_STANDARDIZED #63, [all standardized from] OK
  2. TG2-AMENDMENT_DATEIDENTIFIED_STANDARDIZED #26, TG2-AMENDMENT_DAY_STANDARDIZED #127,TG2-AMENDMENT_EVENT_FROM_EVENTDATE #52, TG2-AMENDMENT_EVENTDATE_STANDARDIZED #61, TG2-AMENDMENT_EVENTDATE_FROM_VERBATIM #86, TG2-AMENDMENT_MONTH_STANDARDIZED #128, TG2-AMENDMENT_MINELEVATIONMAXELEVATION_FROM_VERBATIM #68, [date related ones that mention unambiguously interpreted ... We had lots of dicsussion in Gainsville about unabiguously interpreted with these date terms so I see no problem] OK
  3. TG2-AMENDMENT_MINDEPTHMAXDEPTH_FROM_VERBATIM #55, [I would change the wording to "were unambiguously interpreted from" rather than "were unambiguously determined from" to conform with TG2-AMENDMENT_MINELEVATIONMAXELEVATION_FROM_VERBATIM #68 et al.]
  4. TG2-AMENDMENT_COORDINATES_CONVERTED #43, [This is a special case and the only "Conversion" type] OK
  5. TG2-AMENDMENT_MONTH_STANDARDIZED #128 [could possibly alter to say "unambiguously interpreted as" to conform with TG2-AMENDMENT_MINELEVATIONMAXELEVATION_FROM_VERBATIM #68 et al.] OK
  6. TG2-AMENDMENT_COORDINATES_FROM_VERBATIM #32 [Again a special case - could possibly change "were populated from" to "changed to unambiguously conform to" ].

So I only see #55, #32 and possibly #128 as worth changing.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 13, 2020 via email

@chicoreus
Copy link
Collaborator

Note, FILLED_IN is a special case (and should be defined in the vocabulary, and used whenever applicable), it indicates that a term contained no value, and that some value has been proposed. This is a different case from that where a change was proposed (for which we should also have a consistent vocabulary term). See the RDF....

@ArthurChapman
Copy link
Collaborator

Has now been added to Vocabulary #152

FILLED_IN An Amendment (q.v.) that indicates that a term contained no value, and that some value has been proposed.

@chicoreus
Copy link
Collaborator

That should be a ResultState (or status, forget which we are using) produced by an Amendment... It isn't an amendment, but a result status that can be produced by one.

See ffdq-api:

public static ResultState RUN_HAS_RESULT = new ResultState("HAS_RESULT");
public static ResultState NOT_RUN = new ResultState("NOT_RUN");
public static ResultState INTERNAL_PREREQUISITES_NOT_MET = new ResultState("DATA_PREREQUISITES_NOT_MET");
public static ResultState EXTERNAL_PREREQUISITES_NOT_MET = new ResultState("EXTERNAL_PREREQUISITES_NOT_MET");

public static ResultState CHANGED = new ResultState("CHANGED");
public static ResultState FILLED_IN = new ResultState("FILLED_IN");
public static ResultState NO_CHANGE = new ResultState("NO_CHANGE");

And values we aren't using:

public static ResultState TRANSPOSED = new ResultState("TRANSPOSED");
public static ResultState AMBIGUOUS = new ResultState("AMBIGUOUS");

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 14, 2020

..."default value" ?

Also then, some of the other variants should then be aligned.

"filled in" (but from dwc...) this would also apply to ""were populated from ..." and "added from ..."
"was set to the predefined default value"

But there are still plenty of inconsistencies even so-

"standardized using"
"standardized" without how it was done
"have been" vs "was/were"
"altered" vs "changed"
"using a specified source authority" vs "using the specified source authority"
"determined from.." vs "interpreted from ..." vs "inferred from..."

@ArthurChapman
Copy link
Collaborator

@chicoreus Thanks - we appear to be using "Response"

@Tasilee Tasilee changed the title AMENDMENT_[]_STANDARDIZED source authorities TG2-AMENDMENT_[]_STANDARDIZED source authorities Jun 17, 2020
@Tasilee
Copy link
Collaborator

Tasilee commented Jun 29, 2020

We have a quorum to CLOSE.

@Tasilee Tasilee closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants