-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-VALIDATION_STATEPROVINCE_FOUND #199
Comments
I used "Tasmanian" in the example as the examples are mainly fails. This is something we need to check for consistency. |
Agreed. Done. |
Do we want to be explicit about rank (one way or another) in the specification: Changing EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:stateProvince was EMPTY; COMPLIANT if value of dwc:stateProvince occurs in bdq:sourceAuthority; otherwise NOT_COMPLIANT to EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:stateProvince was EMPTY; COMPLIANT if value of dwc:stateProvince occurs at any rank below country in bdq:sourceAuthority; otherwise NOT_COMPLIANT or EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:stateProvince was EMPTY; COMPLIANT if value of dwc:stateProvince occurs in bdq:sourceAuthority at a rank interpretable as a primary division of a country; otherwise NOT_COMPLIANT or EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:stateProvince was EMPTY; COMPLIANT if value of dwc:stateProvince occurs at any rank in bdq:sourceAuthority; otherwise NOT_COMPLIANT |
I prefer the first example (rank below country) or third. |
I don't think the second one can work in practice. I have an intuition that the third one is too permissive. The first one seems reasonable, but I would state it something like this ("rank" doesn't really work for administrative geography): EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:stateProvince is EMPTY; COMPLIANT if the value of dwc:stateProvince occurs as an administrative entity that is a child to at least one of the entities representing an ISO country-like entity in the bdq:sourceAuthority; otherwise NOT_COMPLIANT |
Agreed and amended as suggested with an addition to the Notes to help explain our intent |
How about a minor change from that s/at least one of the entities/at least one entity/: EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:stateProvince is EMPTY; COMPLIANT if the value of dwc:stateProvince occurs as an administrative entity that is a child to at least one entity representing an ISO country-like entity in the bdq:sourceAuthority; otherwise NOT_COMPLIANT |
Done. |
Added to Notes: "This test will fail if there are leading or trailing white space or non-printing characters." |
…-06-28) specifications. Addressing tdwg/bdq#199 VALIDATION_STATEPROVINCE_FOUND Adding an implementation with metadata and an implementation with default parameter value and a minimal unit test. Renaming GettyCountryLookup to GettyLookup and implementing primary division lookup. Adding primary division caches to singleton.
Post Zoom 11/7/2023, I have aligned the Source Authority with the suggested syntax: bdq:sourceAuthority default = "The Getty Thesaurus of Geographic Names (TGN)" [https://www.getty.edu/research/tools/vocabularies/tgn/index.html] to bdq:sourceAuthority default = "The Getty Thesaurus of Geographic Names (TGN)" {[https://www.getty.edu/research/tools/vocabularies/tgn/index.html]} |
Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated" |
Edited notes to change "fail" text to more specific "This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters." |
Added 3166 qualifier to the ISO ref in the Expected Response and added two ISO 3166 references |
The text was updated successfully, but these errors were encountered: