Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_SCIENTIFICNAMEAUTHORSHIP_NOTEMPTY #244

Open
Tasilee opened this issue Feb 3, 2024 · 3 comments
Open

TG2-VALIDATION_SCIENTIFICNAMEAUTHORSHIP_NOTEMPTY #244

Tasilee opened this issue Feb 3, 2024 · 3 comments
Labels
Completeness CORE TG2 CORE tests NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@Tasilee
Copy link
Collaborator

Tasilee commented Feb 3, 2024

TestField Value
GUID 49f1d386-5bed-43ae-bd43-deabf7df64fc
Label VALIDATION_SCIENTIFICNAMEAUTHORSHIP_NOTEMPTY
Description Is there a value in dwc:scientificNameAuthorship?
TestType Validation
Darwin Core Class dwc:Taxon
Information Elements ActedUpon dwc:scientificNameAuthorship
Information Elements Consulted
Expected Response COMPLIANT if dwc:scientificNameAuthorship is bdq:NotEmpty; otherwise NOT_COMPLIANT
Data Quality Dimension Completeness
Term-Actions SCIENTIFICNAMEAUTHORSHIP_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2024-02-04
Examples [dwc:scientificNameAuthorship="(Györfi, 1952)": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:scientificNameAuthorship is bdq:NotEmpty"]
[dwc:scientificNameAuthorship="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:scientificNameAuthorship is bdq:Empty"]
Source TG2
References
Example Implementations (Mechanisms) Kurator/FilteredPush sci_name_qc Library
Link to Specification Source Code https://github.com/FilteredPush/sci_name_qc/blob/v1.1.2/src/main/java/org/filteredpush/qc/sciname/DwCSciNameDQ.java#L3059
Notes
@Tasilee Tasilee added TG2 Validation NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Completeness labels Feb 3, 2024
@chicoreus
Copy link
Collaborator

There are practical arguments for including this test within the scope of core, as the presence of a value in scientifcNameAuthorship can help implementors with evaluation of the value of scientificName. See the discussion in #46.

@Tasilee
Copy link
Collaborator Author

Tasilee commented Feb 6, 2024

@chicoreus: This test did have a score of 4.5 which supports your thinking. On what criteria would it be considered Supplementary?

  1. Not being widely applicable (no)
  2. Not informative (no)
  3. Not straightforward to implement (no)
  4. Likely to return a high percentage of either bdq:COMPLIANT or bdq:NOT_COMPLIANT results (cf bdq:Response.result) (no- 18% of GBIF records).

@chicoreus
Copy link
Collaborator

@Tasilee one of the very severe problems for implementors of tests around dwc:scientificName is understanding the string content in that name. dwc:scientificNameAuthorship is expected to contain the authorship part of the string, dwc:namePublishedInYear is expected to provide the year of publication (which may or may not be also found in dwc:scientificNameAuthorship. For any tests that are trying to match a string value in a dwc:scientificName with results from an authority, dwc:scientificNameAuthorship and dwc:namePublishedInYear are of substantial value to implementors in understanding whether a match exists or not. This gives the term wide applicability, it is informative, and it it straightforward to implement.

@Tasilee Tasilee added NEEDS WORK CORE TG2 CORE tests and removed NEEDS WORK Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 9, 2024
chicoreus added a commit to FilteredPush/sci_name_qc that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completeness CORE TG2 CORE tests NAME Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
None yet
Development

No branches or pull requests

2 participants