-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ANSI code and RGB colors #148
Add support for ANSI code and RGB colors #148
Conversation
FYI, my first attempt implemented
Since I expected the config to use an array, for example For that reason, I went with a regular struct as I think having r, g and b as the keys is more intuitive than 0, 1 and 2: Edit: the |
I actually prefer the explicit struct with key names 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks pretty straightforward!
Can you also update the README?
(Btw, README is getting a bit long, we should probably use mdbook or something like that in the future...)
Co-authored-by: Danilo Bargen <[email protected]>
@dbrgn Thanks for the review! Let me know if the README update looks fine, or if there's anything more I should add or change. |
Co-authored-by: Danilo Bargen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Closes #147
Allows defining colors as ANSI codes or RGB in
config.toml
e.g.: