Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache: Return error if HTTP client cannot be created #247

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Cache: Return error if HTTP client cannot be created #247

merged 1 commit into from
Jan 8, 2022

Conversation

dbrgn
Copy link
Collaborator

@dbrgn dbrgn commented Jan 2, 2022 •
edited
Loading

Apparently Client::new can panic (see #244), so let's return the error instead.

@dbrgn dbrgn self-assigned this Jan 2, 2022
@dbrgn
Copy link
Collaborator Author

dbrgn commented Jan 2, 2022

Hm, I'm currently converting the codebase to use anyhow, which also affects these error messages, so I'll close this PR.

@dbrgn dbrgn closed this Jan 2, 2022
@dbrgn dbrgn deleted the http-client-error branch January 2, 2022 19:07
@dbrgn dbrgn restored the http-client-error branch January 2, 2022 23:43
@dbrgn dbrgn reopened this Jan 2, 2022
@dbrgn dbrgn mentioned this pull request Jan 2, 2022
Merged
@dbrgn dbrgn merged commit 84277cc into main Jan 8, 2022
@dbrgn dbrgn deleted the http-client-error branch January 8, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dbrgn dbrgn

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dbrgn