wip: make strategy names optional where it makes sense.

team-alembic · Jan 8, 2023 · a62d3ca · a62d3ca
1 parent f117200
commit a62d3ca
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/lib/ash_authentication/dsl.ex b/lib/ash_authentication/dsl.ex
@@ -211,7 +211,7 @@ defmodule AshAuthentication.Dsl do
         end
         """
       ],
-      args: [:name],
+      args: [{:optional, :name, :password}],
       hide: [:name],
       target: Password,
       modules: [:hash_provider],
@@ -302,7 +302,7 @@ defmodule AshAuthentication.Dsl do
     %Entity{
       name: :oauth2,
       describe: "OAuth2 authentication",
-      args: [:name],
+      args: [{:optional, :name, :oauth2}],
       target: OAuth2,
       modules: [
         :authorize_path,
@@ -581,7 +581,7 @@ defmodule AshAuthentication.Dsl do
     %Entity{
       name: :confirmation,
       describe: "User confirmation flow",
-      args: [:name],
+      args: [{:optional, :name, :confirm}],
       target: Confirmation,
       modules: [:sender],
       schema:
@@ -694,6 +694,7 @@ defmodule AshAuthentication.Dsl do
     |> strategy()
     |> Map.merge(%{
       name: :auth0,
+      args: [{:optional, :name, :confirm}],
       describe: "Auth0 authentication",
       auto_set_fields: [
         authorization_params: [scope: "openid profile email"],

diff --git a/test/support/example/user.ex b/test/support/example/user.ex
@@ -132,7 +132,7 @@ defmodule Example.User do
     end
 
     strategies do
-      password :password do
+      password do
         resettable do
           sender fn user, token ->
             Logger.debug(
@@ -142,7 +142,7 @@ defmodule Example.User do
         end
       end
 
-      oauth2 :oauth2 do
+      oauth2 do
         client_id &get_config/2
         redirect_uri &get_config/2
         client_secret &get_config/2
@@ -155,7 +155,7 @@ defmodule Example.User do
         identity_resource Example.UserIdentity
       end
 
-      auth0 :auth0 do
+      auth0 do
         client_id &get_config/2
         redirect_uri &get_config/2
         client_secret &get_config/2