Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(TokenResource)!: Store the token subject in the token resource. #133

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

jimsynz
Copy link
Collaborator

@jimsynz jimsynz commented Jan 13, 2023

This is a breaking change because you may have to delete tokens in your database so that you can avoid the non-null constraint on subject.

…ource.

This is a breaking change because you may have to delete tokens in your database so that you can avoid the non-null constraint on subject.
@jimsynz jimsynz self-assigned this Jan 13, 2023
@jimsynz jimsynz changed the title improvement(TokenResource)!: Store the token subject in the token resource/ improvement(TokenResource)!: Store the token subject in the token resource. Jan 13, 2023
@zachdaniel
Copy link
Collaborator

Since there are people using the package now, I think we should create a documentation/topics/upgrading.md or similar that contains a heading per version with breaking change, explaining what needs to change.

@jimsynz
Copy link
Collaborator Author

jimsynz commented Jan 13, 2023

@zachdaniel I have added an upgrading guide.

Screenshot 2023-01-13 at 3 48 51 PM

@jimsynz jimsynz merged commit 948298a into main Jan 13, 2023
@jimsynz jimsynz deleted the improvement/token-resource-stores-subject branch January 13, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants