Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Google strategy #474

Merged
merged 4 commits into from
Oct 25, 2023
Merged

feat: Add Google strategy #474

merged 4 commits into from
Oct 25, 2023

Conversation

lawik
Copy link
Contributor

@lawik lawik commented Oct 14, 2023

No description provided.

@lawik
Copy link
Contributor Author

lawik commented Oct 14, 2023

I did not test this yet. I also did not figure out how to generate documentation/dsls which says they are generated by spark.

zachdaniel
zachdaniel approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! Let's get it tested in at least one case before merging. But even with that, its almost entirely assent under the hood, so there isn't a whole lot to test from an automation standpoint.

@jimsynz jimsynz merged commit a4f68eb into team-alembic:main Oct 25, 2023
18 checks passed
@jimsynz jimsynz mentioned this pull request Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachdaniel zachdaniel zachdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lawik @zachdaniel @jimsynz