Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if subject of an object is nil before referencing it #2

Merged
merged 1 commit into from
May 30, 2019
Merged

Check if subject of an object is nil before referencing it #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 27 additions & 22 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,27 +159,27 @@ func getPermissions() (Permissions, error) {
p := Permissions{}
sa, err := getServiceAccounts()
if err != nil {
return p, err
return p, err
}
p.ServiceAccounts = sa
p.ServiceAccounts = sa
roles, err := getRoles()
if err != nil {
return p, err
return p, err
}
p.Roles = roles
rb, err := getRoleBindings()
if err != nil {
return p, err
return p, err
}
p.RoleBindings = rb
cr, err := getClusterRoles()
if err != nil {
return p, err
return p, err
}
p.ClusterRoles = cr
crb, err := getClusterRoleBindings()
if err != nil {
return p, err
return p, err
}
p.ClusterRoleBindings = crb
return p, nil
Expand All @@ -196,11 +196,13 @@ func lookupRoles(namespace, sa string, p Permissions) (roles []string, err error
}
roleRef := d["roleRef"].(map[string]interface{})
r := roleRef["name"].(string)
subjects := d["subjects"].([]interface{})
for _, subject := range subjects {
s := subject.(map[string]interface{})
if s["name"] == sa {
roles = append(roles, r)
if d["subjects"] != nil {
subjects := d["subjects"].([]interface{})
for _, subject := range subjects {
s := subject.(map[string]interface{})
if s["name"] == sa {
roles = append(roles, r)
}
}
}
}
Expand All @@ -218,13 +220,16 @@ func lookupClusterRoles(sa string, p Permissions) (clusterroles []string, err er
}
roleRef := d["roleRef"].(map[string]interface{})
r := roleRef["name"].(string)
subjects := d["subjects"].([]interface{})
for _, subject := range subjects {
s := subject.(map[string]interface{})
if s["name"] == sa {
clusterroles = append(clusterroles, r)
if d["subjects"] != nil {
subjects := d["subjects"].([]interface{})
for _, subject := range subjects {
s := subject.(map[string]interface{})
if s["name"] == sa {
clusterroles = append(clusterroles, r)
}
}
}

}
return clusterroles, nil
}
Expand All @@ -233,7 +238,7 @@ func lookupClusterRoles(sa string, p Permissions) (clusterroles []string, err er
// if namespace is empty then the scope is cluster-wide.
func lookupResources(namespace, role string, p Permissions) (resources string, err error) {
if namespace != "" { // look up in roles
for _, roles := range p.Roles[namespace] {
for _, roles := range p.Roles[namespace] {
var d map[string]interface{}
b := []byte(roles)
err = json.Unmarshal(b, &d)
Expand All @@ -253,7 +258,7 @@ func lookupResources(namespace, role string, p Permissions) (resources string, e
}
}
// ... otherwise, look up in cluster roles:
for _, cr := range p.ClusterRoles {
for _, cr := range p.ClusterRoles {
var d map[string]interface{}
b := []byte(cr)
err = json.Unmarshal(b, &d)
Expand Down Expand Up @@ -330,12 +335,12 @@ func genGraph(p Permissions) *dot.Graph {
}
return g
}

// struct2json turns a map into a JSON string
func struct2json(s map[string]interface{})(string, error){
func struct2json(s map[string]interface{}) (string, error) {
str, err := json.Marshal(s)
if err != nil {
return "", err
return "", err
}
return string(str), nil
}
}