Add matrix as a dependency for Ruby 3.1 compatibility

[casperisfine]

It was recently removed from the default gems:

• https://bugs.ruby-lang.org/issues/17873
• Extract bundled gems for Ruby 3.1 ruby/ruby#4530

[coveralls]

Pull Request Test Coverage Report for Build 7830

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 2 files lost coverage.
• Overall coverage remained the same at 97.19%

---

Files with Coverage Reduction	New Missed Lines	%
lib/capybara/queries/text_query.rb	1	98.44%
lib/capybara/selenium/patches/logs.rb	1	72.22%

Totals
Change from base Build 7818:	0%
Covered Lines:	14282
Relevant Lines:	14695

---

💛 - Coveralls

[casperisfine]

Actually this cause double loading warnings for ruby 3.0 and older. I'm not too sure yet how best to fix this.

[twalpole]

I haven’t looked in detail yet, but I can’t think of anywhere that Capybara uses matrix itself. That would imply it’s actually a requirement of a dependency and should be fixed there rather than in Capybara

[casperisfine]

I can’t think of anywhere that Capybara uses matrix itself.

Right here:

capybara/lib/capybara/queries/selector_query.rb

Line 3 in 312ab56

require 'matrix'

[casperisfine]

That being said I don't see it used, it was introduced in b0e3b93 but I see no reference to the Matrix class. So maybe it was a mistake and we can just remove the require?

[twalpole]

Ah, yes -- we use Vector which is provided by the matrix library

[twalpole]

If this is causing double loading warnings on released versions of Ruby then I'm not going to merge it in to fix a dev version of Ruby. For now you'll just need to specify the dependency in your own gemfile

[casperisfine]

If this is causing double loading warnings on released versions of Ruby then I'm not going to merge it

In the end it doesn't, the problem is only with specific gems that bundler use like digest, net/protocol. See: https://bugs.ruby-lang.org/issues/17873

I got this issue with the mail gem, so I posted here quickly too to make sure this wouldn't be merged before I investigate, but I'm confident this can be merged safely now.

For now you'll just need to specify the dependency in your own gemfile

Yeah it's already worked around on our side, but I'm running ruby-head CI specifically to catch this kind of things early so that upgrading to Ruby 3.1 will as smooth as possible in January. So IMHO if this is included early it's better.