Merge pull request #2474 from teamleadercrm/fix/looping-menu-item

[FIX] Looping of menu item
teamleadercrm · Dec 6, 2022 · cea22e4 · cea22e4
2 parents 3a937c4 + a65e1e1
commit cea22e4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,7 +12,13 @@
 
 ### Dependency updates
 
-## [18.1.0] - 2022-12-05
+## [18.1.1] - 2022-12-06
+
+### Fixed
+
+- `Menu`: Fix possibility to have an infinite loop ([@stefaandevylder](http://github.com/stefaandevylder)) in [#2474](https://github.com/teamleadercrm/ui/pull/2474)
+
+## [18.1.0] - 2022-12-0
 
 ### Added
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@teamleader/ui",
   "description": "Teamleader UI library",
-  "version": "18.1.0",
+  "version": "18.1.1",
   "author": "Teamleader <[email protected]>",
   "bugs": {
     "url": "https://github.com/teamleadercrm/ui/issues"

diff --git a/src/components/menu/Menu.tsx b/src/components/menu/Menu.tsx
@@ -205,7 +205,7 @@ const Menu: GenericComponent<MenuProps> = ({
 
     setStateWidth(width);
     setStateHeight(height);
-  }, [menuNode.current?.getBoundingClientRect()]);
+  }, []);
 
   useEffect(() => {
     active ? show() : hide();