This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
DatePickerInput improvements #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubis741
requested review from
lorgan3,
KristofColpaert,
eniskraasniqi1,
BeirlaenAaron,
driesd,
farazatarodi,
jelledc,
JorenSaeyTL,
lowiebenoot and
stefaandevylder
driesd
previously approved these changes
Nov 22, 2022
|
⌛ MC'ing |
lorgan3
previously approved these changes
Nov 22, 2022
lowiebenoot
reviewed
Nov 22, 2022
|
In the stories, the
|
|
Besides the story remark, MC works as advertised ✅ |
driesd
approved these changes
Nov 22, 2022
KristofColpaert
approved these changes
Nov 22, 2022
jelledc
approved these changes
Nov 22, 2022
stefaandevylder
approved these changes
Nov 22, 2022
eniskraasniqi1
approved these changes
Nov 22, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
DatePickerInput: Used proper cursor and added ability to close DatePicker on ESC and ENTER key (@qubis741) in (#2460)Manual check