Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

AdvancedCollapsible: children indent #2515

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Conversation

driesd
Copy link
Contributor

@driesd driesd commented Jan 4, 2023

Description

This PR adds the indent boolean prop to our AdvancedCollapsible component. By default, it's true and can be set to false to remove the indentation of the children's wrapper.

Screenshot with indent (default)

Screenshot 2023-01-04 at 10 30 49

Screenshot without indent

Screenshot 2023-01-04 at 10 30 41

Breaking changes

None

@driesd driesd added the feature label Jan 4, 2023
@driesd driesd self-assigned this Jan 4, 2023
Base automatically changed from set-advanced-collapsible-state to next-release January 4, 2023 09:37
Copy link
Contributor

@lorgan3 lorgan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to suggest this in your pr where you added the negative margin 😄

@driesd
Copy link
Contributor Author

driesd commented Jan 4, 2023

I was about to suggest this in your pr where you added the negative margin 😄

Exactly what triggered me as well :)

@driesd driesd merged commit 20aee40 into next-release Jan 4, 2023
@driesd driesd deleted the AdvancedCollapsible/indent branch January 4, 2023 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants