This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix menu onSelect type #2521
Merged
Fix menu onSelect type #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't make it infer the type at that point. The return type should be equivalent to what it was before
farazatarodi
approved these changes
Jan 10, 2023
driesd
approved these changes
Jan 10, 2023
BeirlaenAaron
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small fix and improvement: The type for
MenuonSelectwas incorrect.I've also updated the type of
selectedso it should be inferred instead of always beingany.Screenshot before this PR
N/a
Screenshot after this PR
N/a
Breaking changes
N/a